Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Localization: Fix links pointing to non-prefixed URLs #504

Closed
MichaelKohler opened this issue Oct 29, 2021 · 2 comments
Closed

Localization: Fix links pointing to non-prefixed URLs #504

MichaelKohler opened this issue Oct 29, 2021 · 2 comments
Labels

Comments

@MichaelKohler
Copy link
Member

MichaelKohler commented Oct 29, 2021

With the latest l10n changes I messed up the active header underline. It's not shown anymore because the link in the header does not yet use the locale prefix.

Additionally there are some other links that directly point to the non-prefixed URL, such as /add which does not work for non-English locales as you get redirected to the EN version when clicking the link.

@MichaelKohler MichaelKohler changed the title Localization: fix active header Localization: Fix links pointing to non-prefixed URLs Oct 30, 2021
@MichaelKohler
Copy link
Member Author

To not make a mess, let's tackle this once #501 is merged.

MichaelKohler pushed a commit that referenced this issue Oct 31, 2021
# [2.12.0](v2.11.3...v2.12.0) (2021-10-31)

### Bug Fixes

* always link to localized URL (fixes [#504](#504)) ([#512](#512)) ([6e66528](6e66528))
* do not use locale prefixed URLs for login/logout ([#506](#506)) ([02053a4](02053a4))
* fix empty page after reviewing last sentence (fixes [#498](#498)) ([728f429](728f429))
* fix typo in sc-lang-info-left-for-you ([#515](#515)) ([313273f](313273f))
* fix upperkey keys not working in Review (fixes [#487](#487)) ([#508](#508)) ([6c3a073](6c3a073))
* make duplicate sentences use plural rules ([#511](#511)) ([ab2c696](ab2c696))
* move LocalizationProvider outwards to not request language on every page navigation ([6a5967e](6a5967e))
* only expose error codes ([2114b38](2114b38))
* show 'Add more sentences' link in stats when no more to review for user ([#516](#516)) ([ae9f1cf](ae9f1cf))
* show native language name only in stats (issue [#492](#492)) ([#514](#514)) ([0086c64](0086c64))
* slight font adjustments ([#505](#505)) ([25ca2e0](25ca2e0))

### Features

* localization: extract English strings into FTL file ([#507](#507)) ([6d64afb](6d64afb)), closes [#501](#501)
@MichaelKohler
Copy link
Member Author

🎉 This issue has been resolved in version 2.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant