Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Ability to see and remove my own sentences #118

Closed
nukeador opened this issue Jan 17, 2019 · 8 comments
Closed

Ability to see and remove my own sentences #118

nukeador opened this issue Jan 17, 2019 · 8 comments
Assignees
@MichaelKohler
Labels
area: profile backend enhancement New feature or request frontend P3

Comments

@nukeador
Copy link

We need a way for a given user to see all sentences they have sent and provide with the ability to remove them, and maybe the same for an admin user.

Context: What happens if a user realizes some of his/her sentences were not public domain?
@nukeador
Copy link
Author

/cc @JRMeyer

@MichaelKohler
Copy link
Member

In terms of Kinto permissions, this should be doable if I read the documentation right:

Every modification of an object (including the creation of new objects) grant the write permission to their creator/editor.

I would need some help in terms of UX though, as there possibly should be search as well?

@nukeador
Copy link
Author

Let's keep this idea parked until we decide priority, no need to think yet about UX here.

@MichaelKohler MichaelKohler mentioned this issue Feb 3, 2019
Merged
@nukeador
Copy link
Author

nukeador commented Feb 3, 2019

How complex a minimum viable version of this would be to implement?

MVP

  • List all my sentences.
  • Button to remove individual ones.
  • Button to remove all from one submission?

Additional features from community feedback

  • See my sentences that have been rejected
  • Search
  • Download all my sentences (and metadata)

@MichaelKohler
Copy link
Member

Per submission will not work, except we start to give unique ids to the submissions. This shouldn't be too complex though.

For seeing sentences which got rejected, there is already #159 on file.

@MichaelKohler
Copy link
Member

For now let's go with the following:

  • Additional section in the menu "My sentences"
  • Sentences that got submitted by the current user are listed there (similar to the upcoming 'Rejected Sentences')
  • Each sentence has a remove button next to it
  • Clicking the button removes the sentences from the database

@MichaelKohler
Copy link
Member

PR for 'Rejected Sentences' as inspiration on how to tackle this: https://github.com/Common-Voice/sentence-collector/pull/219/files. This will show how to change the navigation, and how to add new pages. Of course the content and file names would need to be different for this PR ;)

@MichaelKohler MichaelKohler added P3 and removed P2 labels Mar 7, 2021
@MichaelKohler MichaelKohler mentioned this issue May 27, 2021
Closed
@MichaelKohler MichaelKohler self-assigned this Jun 27, 2021
MichaelKohler pushed a commit that referenced this issue Jun 27, 2021
@semantic-release-bot
chore(release): 2.5.0
279a8a5 
# [2.5.0](v2.4.11...v2.5.0) (2021-06-27)

### Bug Fixes

* do not show skipped sentences again in Swipe Review Tool (fixes [#421](#421)) ([c5154b1](c5154b1))
* move user stats to user endpoint (fixes [#423](#423)) ([28f87f3](28f87f3))

### Features

* add sentence overview and possibility to delete own sentences (fixes [#118](#118)) ([94bd170](94bd170))
@MichaelKohler
Copy link
Member

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaelKohler MichaelKohler

Labels
area: profile backend enhancement New feature or request frontend P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelKohler @nukeador