Filters - Filter Menu - menu header #2951
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
ddouglasz
requested review from
stephsprinkle,
jaikamat,
tylermorrisford,
ByronDWall,
misama-ct and
a team
and removed request for
a team
| @@ -16,5 +17,6 @@ export default meta; | |||
| type Story = StoryFn<typeof Filters>; | |||
|
|
|||
| export const BasicExample: Story = () => { | |||
| return <Filters label={'test'} />; | |||
| // return <Filters label={'test'} />; | |||
There was a problem hiding this comment.
only for testing purposes, I will return back to its state before merging
| {props.onSort && ( | ||
| <IconButton | ||
| size="20" | ||
| theme={isActive ? 'info' : 'default'} |
There was a problem hiding this comment.
You might notice a slight change between the IconButton when Active. This is because "round" prop is deprecated and I have checked in with Filip to confirm we are using the new prop design(square).
.changeset/dirty-coins-begin.md
Outdated
| '@commercetools-uikit/filters': minor | ||
| --- | ||
|
|
||
| Implement FilterMenu header component. |
There was a problem hiding this comment.
I don't think we need a changeset here, since we aren't publishing filters for public consumption until the entire feature is done
There was a problem hiding this comment.
updated here: 270993d
Thank you
| operatorOptions?: Array<TOption>; | ||
| onSelectOperand: (value: string) => void; |
There was a problem hiding this comment.
This is my fault, because I should have updated the jira ticket, but these should be a single renderOperatorsInput: () => ReactNode
Description
Add Filters - Filter Menu - menu header component.
This pull request introduces a new
FilterMenuheader component and updates related files to support its implementation. The changes include adding new props to theFilterMenucomponent, updating tests, and modifying the storybook example.Implementation of
FilterMenuheader component:.changeset/dirty-coins-begin.md: Added a minor change entry for the newFilterMenuheader component.packages/components/filters/src/filter-menu/header/header.tsx: Implemented theHeadercomponent with new props and styles, includinglabel,operandOptions,renderOperandsInput,onSelectOperand,onSort, andmenuHeaderWidth.Updates to
FilterMenucomponent:packages/components/filters/src/filter-menu/filter-menu.tsx: Updated theFilterMenucomponent to include the newHeadercomponent with its props.Test updates:
packages/components/filters/src/filter-menu/header/header.spec.tsx: Enhanced tests for theHeadercomponent to cover new functionalities like conditional rendering ofSelectInputandIconButton.Storybook update:
This task ideally should have no story so after testing, the story modification will be taken off.