fix: filter out unchanged taxrates from changed list #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c92cbac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1914 +/- ##
=======================================
Coverage 94.63% 94.64%
=======================================
Files 147 148 +1
Lines 5089 5097 +8
Branches 1382 1383 +1
=======================================
+ Hits 4816 4824 +8
Misses 270 270
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Ibidapo
approved these changes
Sep 16, 2024
ajimae
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Great job @antoniolodias,
Even though it's not strictly needed, I still think it will be nice if we can add an test assertion to show that the unchanged tax rates were completely omitted in the resulting action.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
support ticket
When trying to update one tax rate inside a tax category, all the tax rates for the tax category are updated by the API.
Description
This happens because there's no
updateaction for taxRates, but onlyreplace, so any taxRate sent to the API is taken to be replaced.Tried just filtering out from the FE, but that conflicted with
removelogicThis PR just filters out unchanged tax rates from the action
Todo
Typelabel for the PR