Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Feature/small improvements #227

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Feature/small improvements #227

merged 1 commit into from
Jul 13, 2016

Conversation

teiling88
Copy link
Contributor

some small improvements ;-)

@jenschude
Copy link
Contributor

Hi,

the first commit is a good addition, as it's more explicit in the usage of pathes and quotes.

But I would not merge b0d913e. Therefor see also sebastianbergmann/phpunit/issues/1914

@teiling88
Copy link
Contributor Author

ok he recommends that normal php unit user should use $this-> instead of self::. But why?
In a technical point of view this is not correct but the common usage seems to be with $this->. Every hit on google links to this issue :-\

Can you provide some more information for me please?

@jenschude
Copy link
Contributor

jenschude commented Jul 6, 2016

I also only found the information from this issue. There are some which say how to get rid of some $this writings, but actually most of them still use the instance method call. And as Sebastian said the reason for the static methods was to be able to use the assertion class outside of PHPUnit and as he recommend I would stick to the PHPUnit convention of $this.

@teiling88
Copy link
Contributor Author

that's ok :-) i removed the last commit.

@jenschude jenschude merged commit 2860298 into commercetools:develop Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants