-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in-memory cache for jwks to the jwtVerify
method
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for commercelayer-js-auth-nextjs canceled.
|
marcomontalbano
changed the title
In memory cache verify
Introduce an in-memory cache for jwks to the Aug 21, 2024
jwtVerify
method
marcomontalbano
changed the title
Introduce an in-memory cache for jwks to the
Add in-memory cache for jwks to the Aug 21, 2024
jwtVerify
methodjwtVerify
method
marcomontalbano
force-pushed
the
in-memory-cache-verify
branch
from
August 24, 2024 16:46
49e245e
to
3bdc0a1
Compare
alessani
approved these changes
Aug 26, 2024
marcomontalbano
requested review from
alessani
and removed request for
alessani
August 26, 2024 15:45
malessani
previously approved these changes
Aug 26, 2024
…le in the decoded payload
marcomontalbano
force-pushed
the
in-memory-cache-verify
branch
from
August 30, 2024 09:49
53b21da
to
f7703ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added an in-memory cache for jwks to the
jwtVerify
method trying to reduce rate-limiting errors.I also added the
jwk
option to thejwtVerify
. This way you can cache thejwt
on your own and send the key to method for verification.