Merge pull request #87 from commercelayer/update-token-iss

Update tests with the new token iss
commercelayer · Aug 24, 2024 · cd13d0b · cd13d0b
2 parents 58080ff + 0fe8d73
commit cd13d0b
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -63,3 +63,4 @@ jobs:
           VITE_TEST_PROVISIONING_DOMAIN: ${{ vars.VITE_TEST_PROVISIONING_DOMAIN }}
           VITE_TEST_PROVISIONING_CLIENT_ID: ${{ secrets.VITE_TEST_PROVISIONING_CLIENT_ID }}
           VITE_TEST_PROVISIONING_CLIENT_SECRET: ${{ secrets.VITE_TEST_PROVISIONING_CLIENT_SECRET }}
+          VITE_TEST_TOKEN_ISS: ${{ vars.VITE_TEST_TOKEN_ISS }}
diff --git a/packages/js-auth/global.d.ts b/packages/js-auth/global.d.ts
@@ -17,5 +17,6 @@ declare namespace NodeJS {
     VITE_TEST_PROVISIONING_DOMAIN: string
     VITE_TEST_PROVISIONING_CLIENT_ID: string
     VITE_TEST_PROVISIONING_CLIENT_SECRET: string
+    VITE_TEST_TOKEN_ISS: string
   }
 }
diff --git a/packages/js-auth/src/authenticate.spec.ts b/packages/js-auth/src/authenticate.spec.ts
@@ -7,6 +7,7 @@ const domain = process.env.VITE_TEST_DOMAIN
 const scope = process.env.VITE_TEST_SCOPE
 const username = process.env.VITE_TEST_USERNAME
 const password = process.env.VITE_TEST_PASSWORD
+const tokenIss = process.env.VITE_TEST_TOKEN_ISS
 
 describe('Organization auth', () => {
   it('should throw an error when the clientId is not valid.', async () => {
@@ -66,7 +67,7 @@ describe('Organization auth', () => {
           enterprise: true,
           region: 'eu-west-1'
         },
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         scope: 'market:all',
         test: true
       }
@@ -114,7 +115,7 @@ describe('Organization auth', () => {
           enterprise: true,
           region: 'eu-west-1'
         },
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         scope: 'market:all',
         test: true
       }
@@ -175,7 +176,7 @@ describe('Organization auth', () => {
           geocoder_id: null,
           allows_external_prices: false
         },
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         scope,
         test: true
       }
@@ -247,7 +248,7 @@ describe('Organization auth', () => {
           geocoder_id: null,
           allows_external_prices: false
         },
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         scope,
         test: true
       }
@@ -296,7 +297,7 @@ describe('Provisioning auth', () => {
         typ: 'JWT'
       },
       payload: {
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         application: {
           kind: 'user',
           public: false
@@ -422,7 +423,7 @@ function runJWTBearerTests(
         custom_claim: {
           app: 'supabase'
         },
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         organization: {
           enterprise: true,
           region: 'eu-west-1',
@@ -482,7 +483,7 @@ function runJWTBearerTests(
           type: 'User',
           id: process.env.VITE_TEST_USER_ID
         },
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         organization: {
           enterprise: true,
           region: 'eu-west-1',
@@ -547,7 +548,7 @@ function runJWTBearerTests(
           type: 'Customer',
           id: process.env.VITE_TEST_CUSTOMER_ID
         },
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         organization: {
           enterprise: true,
           region: 'eu-west-1',
@@ -622,7 +623,7 @@ function runJWTBearerTests(
           first_name: 'John',
           last_name: 'Doe'
         },
-        iss: 'https://commercelayer.io',
+        iss: tokenIss,
         organization: {
           enterprise: true,
           region: 'eu-west-1',

diff --git a/packages/js-auth/src/jwtDecode.ts b/packages/js-auth/src/jwtDecode.ts
@@ -61,7 +61,7 @@ interface JWTBase {
   rand: number
   /** Issued at (seconds since Unix epoch). */
   iat: number
-  /** Who created and signed this token (e.g. `"https://commercelayer.io"`). */
+  /** Who created and signed this token (e.g. `"https://auth.commercelayer.io"`). */
   iss: string
 }