Sequences that hit max should stop grabbing values #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a sequence option (one with IEnumerable or similar type) has a Max=N assigned, then once it has hit N values it will stop grabbing values from the command line, and any remaining values will be able to be assigned to other properties with the Value attribute.
This was referenced Aug 19, 2020
|
Thanks @rmunn for this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a sequence option that has Max=N has hit N values, it will stop grabbing values from the command line, and any remaining values will be able to be assigned to other properties with the Value attribute.
Fixes #681.
Two unit tests had incorrect semantics, as discussed in #681, so this also changes those two tests to expect the correct behavior for sequences with Max=N. I also fixed a spelling mistake (gererates instead of generates) while I was working in the InstanceBuilderTests.cs file on one of those two unit tests.