Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: opendbc: symlink fix and use the latest ref #2103

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Dockerfile: opendbc: symlink fix and use the latest ref #2103

merged 1 commit into from
Dec 11, 2024

Conversation

sunnyhaibin
Copy link
Contributor

Description

  • Updated Dependency Reference: Updated OPENDBC_REF to a new commit hash (commaai/opendbc@551081b) to use the latest version of the commaai/opendbc repository.
  • Fix in Symlink Creation Order: Adjusted the sequence so that the symbolic link to the opendbc directory is created before running the scons build process, resolving potential setup or reference issues
  • Improved Build Process: Ensured the build commands (scons) work more reliably by properly referencing the opendbc symlink beforehand.

@devtekve devtekve mentioned this pull request Dec 11, 2024
Closed
@adeebshihadeh adeebshihadeh merged commit dfa033d into commaai:master Dec 11, 2024
10 checks passed
@adeebshihadeh adeebshihadeh deleted the docker-opendbc-fix branch December 11, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnyhaibin @adeebshihadeh