keep unneeded trans off

commaai · Aug 5, 2023 · 80ceecb · 80ceecb
1 parent 6610982
commit 80ceecb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/board/jungle/boards/board_v1.h b/board/jungle/boards/board_v1.h
@@ -49,6 +49,7 @@ void board_v1_set_can_mode(uint8_t mode) {
       set_gpio_alternate(GPIOB, 5, GPIO_AF9_CAN2);
       set_gpio_alternate(GPIOB, 6, GPIO_AF9_CAN2);
       can_mode = CAN_MODE_NORMAL;
+      board_v1_enable_can_transciever(2U, true);
       break;
     case CAN_MODE_OBD_CAN2:
       print("Setting OBD CAN mode\n");
@@ -60,13 +61,12 @@ void board_v1_set_can_mode(uint8_t mode) {
       set_gpio_alternate(GPIOB, 12, GPIO_AF9_CAN2);
       set_gpio_alternate(GPIOB, 13, GPIO_AF9_CAN2);
       can_mode = CAN_MODE_OBD_CAN2;
+      board_v1_enable_can_transciever(4U, true);
       break;
     default:
       print("Tried to set unsupported CAN mode: "); puth(mode); print("\n");
       break;
   }
-  board_v1_enable_can_transciever(2U, true);
-  board_v1_enable_can_transciever(4U, true);
 }
 
 void board_v1_set_harness_orientation(uint8_t orientation) {

diff --git a/board/jungle/boards/board_v2.h b/board/jungle/boards/board_v2.h
@@ -146,6 +146,7 @@ void board_v2_set_can_mode(uint8_t mode) {
       set_gpio_pullup(GPIOB, 6, PULL_NONE);
       set_gpio_alternate(GPIOB, 6, GPIO_AF9_FDCAN2);
       can_mode = CAN_MODE_NORMAL;
+      board_v2_enable_can_transciever(2U, true);
       break;
     case CAN_MODE_OBD_CAN2:
       // B5,B6: disable normal mode
@@ -161,12 +162,11 @@ void board_v2_set_can_mode(uint8_t mode) {
       set_gpio_pullup(GPIOB, 13, PULL_NONE);
       set_gpio_alternate(GPIOB, 13, GPIO_AF9_FDCAN2);
       can_mode = CAN_MODE_OBD_CAN2;
+      board_v2_enable_can_transciever(4U, true);
       break;
     default:
       break;
   }
-  board_v2_enable_can_transciever(2U, true);
-  board_v2_enable_can_transciever(4U, true);
 }
 
 bool panda_power = false;