Prevent OP engagement when in "Cruise Mode"

[Gernby]

This is a fix for a safety issue that I discovered by accident in my 2018 Honda Accord. If I press and hold the ACC following distance button for a number of seconds, the adaptive component of ACC becomes disabled, so the radar is no longer used to control speed. However, OP works as usual, which seems very dangerous. This PR fixes that by ensuring that ACC is fully enabled.

[rbiasini]

nice finding. Makes sense applying this change. Since it's not 100% sure that it will be an ok change on all Hondas, I'll merge this internally first.

[illumiN8i]

Toyota has this problem too.

[rbiasini]

@illumiN8i it's only a problem if the DSU is plugged I assume, right?

[illumiN8i]

No, with DSU unplugged this trick can be used to bypass cruise fault and engage anyway without ACC.

[rbiasini]

ah, then it definitely needs to be fixed. Good catch. @illumiN8i Feel free to open a separate PR, otherwise I'll open one myself in the coming days.

[Gernby]

Why was this closed?

[rbiasini]

Because it's merged internally and it will go through the standard release process instead of directly into devel. See my comment ^^

[Gernby]

I saw that comment, but wasn't aware of a standard practice to close PR's instead of merging them. It really kills the fun of contribution if there's no credit for it.

[rbiasini]

Well, either it gets merged directly and/or you get credited in the release notes.
What else can we do? For some changes, a deeper validation is required before it goes out to hundreds of users.

[illumiN8i]

@rbiasini Not sure how to fix it, but here's a segment showing the press and hold trick being used to bypass cruise fault and engage anyway without ACC on 2018 Toyota Prius Prime b29e3bc918751697|2019-08-04--12-53-50--9

[Gernby]

@rbiasini - I see that this fix is in 0.6.3, but not mentioned in the release notes.