athenad: refactor deviceState handling with centralized SubMaster #34512
+37
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
athenad_safe_update_sm
branch
from
5202768 to
d608aae
Compare
deanlee
force-pushed
the
athenad_safe_update_sm
branch
from
d608aae to
662a9b3
Compare
deanlee
force-pushed
the
athenad_safe_update_sm
branch
from
662a9b3 to
5c2a383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
NetworkStatusclass to centralizedeviceStatemanagement and improve efficiency.Changes:
Replaces the creation of multiple
SubMaster(['deviceState'])instances in theupload_handlerthreads with a single shared instance, enhancing performance and reducing resource usage.Provides thread-safe methods to update and read network status (metered, network_type).