ci: Ditch docker #34502
ci: Ditch docker #34502
Conversation
| # build our docker image | ||
| start=$(date +%s) | ||
| cd ~/apt-cache/archives | ||
| sudo dpkg -i *.deb || sudo apt-get install -f -y |
There was a problem hiding this comment.
Adding this step to save 5 seconds on sudo apt update.
Will improve in future commits.
|
I'm thinking of creating a shell script like this example to cache APT dependencies. Any suggestions for improvement are welcome! |
| path = Path(os.path.join("/sys/fs/pstore/", fn)) | ||
| if path.is_file(): | ||
| with open(path, "rb") as f: | ||
| expected_val = f.read() | ||
| bootlog_val = [e.value for e in boot.pstore.entries if e.key == fn][0] | ||
| assert expected_val == bootlog_val | ||
|
|
||
| path = Path(os.path.join("/sys/fs/pstore/", fn)) | ||
| try: | ||
| file_exists = path.is_file() | ||
| except PermissionError: | ||
| file_exists = False | ||
| if file_exists: | ||
| with open(path, "rb") as f: | ||
| expected_val = f.read() | ||
| bootlog_val = [e.value for e in boot.pstore.entries if e.key == fn][0] | ||
| assert expected_val == bootlog_val |
There was a problem hiding this comment.
While running unit tests on the Ubuntu runner, I encountered a permission error for /sys/fs/pstore/. couldn't find a solution, so I made this temporary change.
There was a problem hiding this comment.
you can check the error in this alankritdabral#22
|
Overall can you remove all changes like formatting and only commit what is absolutely necessary |
| @@ -18,15 +18,9 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
| env: | |||
| PYTHONWARNINGS: error | |||
| BASE_IMAGE: openpilot-base | |||
| PYTHONWARNINGS: "ignore::DeprecationWarning" | |||
There was a problem hiding this comment.
We shouldn't need this
There was a problem hiding this comment.
Its giving a deprecation warning regarding setuptools and distutils. I have tried with many versions of Python, and this was the only solution I could get.
|
This isn't even remotely close to 20s? |
|
Closing this for now. A 300 lines diff for less than a 10s speedup is not worth it in this state. Also, before asking for review, please address and fix the already existing reviews. If you want to try this again, make sure to re-read the original issue. |
#30706
Removing Docker and using uv cache along with actions/cache for APT.
Docker runtime for setup-with-retry: ~60 sec
Without Docker runtime for setup-with-retry: ~50 sec
Breakdown: