Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op.sh: adb #34468

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

op.sh: adb #34468

wants to merge 4 commits into from

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jan 24, 2025

makes it easier so that you automatiaclly put into directory usr/comma and TERM=xterm-256-color

leaving into draft since although this works it would be nice to go into adb shell as comma user and not root.

@BBBmau BBBmau changed the title add op adb op.sh: adb Jan 24, 2025
@github-actions github-actions bot added the tools label Jan 24, 2025
@adeebshihadeh
Copy link
Contributor

Can we configure this on the device side so adb shell just works?

@BBBmau
Copy link
Contributor Author

BBBmau commented Jan 25, 2025

Can we configure this on the device side so adb shell just works?

i tried looking for a way to configure but unfortunately adbd doesn't allow customization

This seems like the only way from what i've come across to improve the adb shell experience. I'll give it one more try since it seems like we should be able to based off of https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#RootDirectoryStartOnly=

edit: yeah any sort of changes to https://github.com/commaai/agnos-builder/blob/master/userspace/files/adbd.service will just result in a failure.

@BBBmau
Copy link
Contributor Author

BBBmau commented Jan 25, 2025

gives you the same functionality that you get from ssh from just running op adb. Only downside is needing to type exit twice.

  • exit to leave the su comma session
  • exit to leave adb shell

image

@BBBmau BBBmau marked this pull request as ready for review January 25, 2025 03:33
@BBBmau
Copy link
Contributor Author

BBBmau commented Jan 25, 2025

when adb is not active:

image

@adeebshihadeh
Copy link
Contributor

Marking as draft - I'd really only consider this once we've really given up on getting adb shell straight up working like this. I don't see why it's not possible.

@adeebshihadeh adeebshihadeh marked this pull request as draft January 28, 2025 22:10
@BBBmau
Copy link
Contributor Author

BBBmau commented Jan 28, 2025

Fair, I'll look into it more. I'm also not entirely convinced that this method is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants