Hyundai CAN FD: fix spotty ECU responses #32601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
commented
Jun 3, 2024
| [HYUNDAI_VERSION_REQUEST_LONG], | ||
| [HYUNDAI_VERSION_RESPONSE], | ||
| ), | ||
|
|
||
| # CAN & CAN-FD queries (from camera) | ||
| Request( |
There was a problem hiding this comment.
try sending different query/tester present and see if the OBD HYUNDAI_VERSION_REQUEST_LONG response still comes back (failure to multiplex?)
There was a problem hiding this comment.
there's still an ECU on the bus that occasionally sends random queries to the camera we'll have to work around
|
Closing in favor of: commaai/panda#1967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to figure out why this happens only for this specific user so far. Closes #32070
Don't see how this could be a fingerprinting (openpilot) bug, so will do some debugging to root cause it with the user tomorrow!