Kia and Hyundai Support #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openpilot 0.3.4
openpilot v0.3.5 release
openpilot v0.3.6
openpilot v0.3.6.1
openpilot v0.3.7
openpilot v0.3.8.2
openpilot v0.3.9
openpilot v0.4.0.1
openpilot v0.4.0.2
openpilot v0.4.1
openpilot v0.4.1 hotfix
Taiwanese Prius Prime fingerprint was identical to the regular prime (107 msgs.), but should really have 110. I have the correct one in there now.
* Honda Pilot 2017 Port (commaai#161) * Update README.md * Update fingerprints.py * Update carstate.py * Update hondacan.py * Update interface.py * Update interface.py * Update interface.py * Update README.md * Update README.md * Update README.md * Update fingerprints.py * Update carstate.py * Update hondacan.py * Update interface.py * Update carstate.py * Update hondacan.py * Update README.md * Update fingerprints.py * Update carstate.py * Update carstate.py * Update carstate.py * Update hondacan.py * Update interface.py * Update carstate.py * Update carstate.py * Update Pilot Fingerprint * Update fingerprints.py * Give pilot its own definition and not use ILX * add pilot argument * Add Pilot interface * Add pilot argument * Update interface.py * Parse Different gear on pilot * Add steer max * Fixed duplication of steer max value * Adjust PID's for steering * Update carcontroller.py * Change Steer Ratio and wheelbase * Update Steer fault values Steer fault value of 3, does not seem to effect anything * Update Kp,Ki Ratio * Update interface.py * Update readme for Pilot * add pilot * Update fingerprints.py * Update carstate.py * add signals * add signal * fix restricting video upload to wifi * Dibs on SAFETY_GM numerical value To match Panda repo. * Safety Reference for Honda Bosch * Update fingerprints.py (commaai#210) Consolidated my fingerprint and removed duplicates and ordered the fingerprint for the RAV4H. Double Checked. * Interpolate ki/kp for steering PID loop (commaai#200) * Interpolate ki/kp for steering PID loop Very much needed for the Volt port: car ping-pongs with low kp on high speeeds, and the loop is unstable with high kp on low speeds. Also, removes "number or array?" logic from PIController, now that all the callers use interpolation ofr ki/kp. * Pass speed to steering PID loop for ki/kp interpolation * Remove unused numbers import * Slight changes to UI and Fingerprint for Odyssey Elite (commaai#196) * Adding back drive time to UI * Add fingerprint for Odyssey Elite * Removed extended fingerprint for Elite * Revert "Adding back drive time to UI" This reverts commit b9b02f7. * Squashed 'panda/' changes from 98f29a4..67d5208 67d5208 fix signedness issue in toyota safety fe15d3f bump pandacan 11c2b08 add fault invalid 2c26e45 add sleep 27c7637 forgot the counter 3a6d7db don't hang bfa7d2e canloader works b259e2a can flasher is close to working 83f2edf isotp can support in softloader 7ae7c79 typo e85cc47 forgot the selfs 190b4f6 start work on canflasher 5c655c9 add recover support ae3457f usbflash is reliable f7a0ab0 pedal usbflash works 585d0f9 add way to call isotp be82899 despite it being bad code, move isotp 000715b start work on pedal canloader 626e312 pedal has a bootstub now 3662d1e redundant check 81e6b0d fix bug 083cd12 should have bounty to refactor that ish b65d30c bad asserts b2e6c3f isotp untested support for subaddr 30fd66a Merge pull request commaai#93 from vntarasov/volt 06f5109 Merge pull request commaai#94 from gregjhogan/can-printer-hex c7d098c Merge pull request commaai#95 from gregjhogan/setup-script 22fe250 Merge pull request commaai#99 from gregjhogan/bit-transition-example ba16ba3 Merge pull request commaai#100 from gregjhogan/j2534-troubleshooting-instructions ad08ea4 Merge pull request commaai#90 from gregjhogan/can-forwarding f3b6f5d added j2534 troubleshooting instructions 858d150 added script to find bits that transition from 0 to 1 c6acac8 added checking pedal interceptor message length f7226ff added brake safety checks d0c2634 added gas safety checks d378e4a removed bosch safety forwarding restriction on 29 bit addresses 5c7ef9e added bosch safety hooks and forwarding 90c64b6 add note 23de8d4 Merge pull request commaai#97 from commaai/pedal_improvements 0261641 added missing python packages b92b235 fix bytearray encode issue 2434f1c Tweak Volt's brake pedal stickiness e2f73d2 enable has a whole byte to itself d5a9e1e correct checksum f8ed9fa better names 986a14c don't alias pointers 9b8472e add watchdog support 8f0add9 handle faults 1d917f8 split gas set into 2 values, and have a fault state 1b77026 j2534 isn't alpha anymore fbcc872 Merge pull request commaai#92 from commaai/pedal 8a6f44b pedal is sending messages 08f464c python 3 bro is bad bro 9390961 kline checksum algo was broken... 3b7c33b add kline debug support aa622bc init values 631ea9f better refactor eb1fd75 add PEDAL adc sets ccaa310 don't build with usb 8d4d763 debug console works bd09883 comma pedal is building 75a29d5 Merge pull request commaai#84 from gregjhogan/j2534-hds eece37d only the panda has gmlan 9f43abe Merge pull request commaai#89 from vntarasov/volt 5364d43 Merge pull request commaai#88 from vntarasov/smaller-firmware 377a1ec bump version for descriptor fix 4fabdf0 Merge pull request commaai#87 from gregjhogan/usb-multi-packet-control 8580773 fix sending WinUSB Extended Properties Feature Descriptor 6908feb Chevy Volt safety 786a004 Enable optimization to reduce firmware size d70f43b hack to fix thinkpad 95ab1ae fixed flow control message padding bbd04d1 updated installer 62216d0 single standalone DLL for J2534 driver 5c9138d fixed 11 bit address issue f3b0ad2 fix LOOPBACK getting set when DATA_RATE is set b750d36 updated README a9a097f lowered CPU utilization 7c26a70 TIS needs unsupported protocols to return an error 42692b4 TIS doesn't like ChannelID being zero cf126bb SET_CONFIG return error for reserved parameters 2e99dbf fix HDS issues 8203cc8 add is_grey e946a54 add insecure_okay flag 4363b3e check webpage 4f59ded add secure mode note 6b11fb5 add autosecuring to tests b27d185 Merge pull request commaai#86 from commaai/better_pairing 4b53b42 elm wifi isn't an automated test 99f85cb Merge pull request commaai#85 from gregjhogan/usb-wcid 0d38060 auto-install WinUSB device driver c6653ca from python import 38cc0ee add wifi_secure_mode, boots in insecure mode git-subtree-dir: panda git-subtree-split: 67d5208 * Squashed 'opendbc/' changes from 81d9871..aa067f7 aa067f7 Chevy Volt tweaks (commaai#83) a60c6c4 Toyota: change signal name in EPS_STATUS msg ce70b1a extra setme field toyota LKAS_HUD df2a552 toyota missing ACC_CONTROL checksum 48bb293 Revert "Toyota Prius: added a comma specific message to control the speed sent to the EPS" 5f42439 Toyota Prius: added a comma specific message to control the speed sent to the EPS 6f5e8b6 Pedal Interceptor: fault state VAL moved to _comma efd5f5c add setme to honda ACC_HUD 97fc335 add interceptor to civic 6f40f16 update generator script to allow for multiple imports 9ca956b add setme to toyota STEERING_IPAS e5afa57 run generator for ipas scaling 8bd1182 Toyota IPAS: proper steer angle unit f57511e acceleration pedal for gasPressed c8d1dbc high beams also. likely dashboard message. 9f1c78b high beams for genericToggle f037d42 turn signal lights (and thus hazard lights) b35bb08 turn signals 78986cf Revert "turn signals" ba946c9 turn signals 2af3ecc Speed, braking, and distance signals f40ab87 Set packet lengths, adding steering rate, adjusted speed cd59bfa units for speed_right c2fcce2 speed of right vs left side of car 4ef5fae value table for gear status 97c48e2 tighten up speed bits. brake pressue max comment. a0cbfd1 add gear status PRNDL 0c82865 initial signals for chrysler pacifica 2017 hybrid 5ed0540 add set me to toyota LKAS_HUD aecac5d add set me fields to toyota ACC_HUD 5417013 update toyota ACC_CONTROL fields e91e967 Comma Pedal: made GAS_COMMAND 6 bytes d04434a Comma Pedal: added state byte and enable bit c30b2cd Comma Pedal: sending 2 tracks on 0x200 8f72467 Volt doors and belts status (commaai#70) 60f8b6c add set me to lkas hud honda 3c9e335 fix honda pcm gas message size 7ca471d Add 2018 Toyota CHR dbc (commaai#78) 637fe00 set scaling to 1 for brake and gas which have no real unit 62a88d4 Volt: switch to parsing ACC buttons from powertrain CAN (commaai#74) 3fdd47b Volt's gas pedal only and combined gas/acc (commaai#76) 45ec9c9 Add 2017 Honda Ridgeline (commaai#77) cbd186a Add 2018 Camry Hybrid DBC's (commaai#73) 974eeaf Toyota: re-generated the files after cfbc9ae 19ea195 Toyota: more vals for LKA_STATE cfbc9ae fixed inconsistent factor for speed in Honda dbc files e7db803 convert all line endings to unix style git-subtree-dir: opendbc git-subtree-split: aa067f7 * openpilot v0.4.3 release * Squashed 'panda/' changes from 67d5208..3125232 3125232 bump version 703c0b4 Gas Interceptor: another fix to gas pressed logic 196d383 Interceptor: fixed gas pressed logic git-subtree-dir: panda git-subtree-split: 3125232 * Squashed 'opendbc/' changes from aa067f7..91e882d 91e882d Updating bosch dbcs to use new format and bringing in new honda changes (commaai#82) 9b32e2e Fix Checksum errors for CH-R (commaai#86) git-subtree-dir: opendbc git-subtree-split: 91e882d * openpilot v0.4.3 release * openpilot v0.4.3.1 release * fix bug in canpacker for Toyotas with DSU connected (commaai#221) * update year on civic
This reverts commit 640ab12.
Revert "openpilot 0.4.3.1"
openpilot 0.4.5.1 release
0.4.6 Release
openpilot 0.4.7.1
starting this over due to the refactor
Zero Point of Steering Control is now Constant to increase readability of code Steering Torque Rate Limit is now based from GM Port Steering Torque Driver Limit is now based from GM Port
…ONE. This may work, it may do nothing!
All major differences between makes and models are now set in values.py LKAS Messages can be fully created by OpenPilot OR augmented, and require the stock camera This can be set in values.py Tuning has been tweaked, it is better, but still not perfect Thanks to @TK211X for the tuning
I know this still allows steering, and it does compile flash and run But there is no guarentee it actually works or even does anything This MUST be tested, but on the off chance it is working just fine, better to have it here than not at all
rbiasini
reviewed
Aug 2, 2018
| elif cp.vl["CLU15"]["CF_Clu_InhibitP"] == 1: | ||
| self.gear_shifter = "park" | ||
| elif cp.vl["CLU15"]["CF_Clu_InhibitR"] == 1: | ||
| self.gear_shifter = "reverse" |
There was a problem hiding this comment.
are the cruise buttons (set/resume) on can?
If you aren't driving a sorento, make sure you keep your tuning Update the spreadsheet Help everyone, and your tunings WILL become part of the port
rbiasini
reviewed
Aug 29, 2018
selfdrive/car/hyundai/interface.py
Outdated
|
|
||
| # TODO: start from empirically derived lateral slip stiffness for the civic and scale by | ||
| # mass and CG position, so all cars will have approximately similar dyn behaviors | ||
| ret.tireStiffnessFront = tireStiffnessFront * ret.mass * (centerToRear / ret.wheelbase) |
There was a problem hiding this comment.
@emmertex this is an important bug: seem my port for correct dimensional scaling.
As is, car should strongly underestimate the needed steering angle to make a turn
|
obsoleted by #346 |
pd0wm
pushed a commit
that referenced
this pull request
Dec 14, 2019
a648cca Add os import 042562d Extracted wifi connect from test helpers ac0fd5d query fw versions example - use extended diagnostic session 4e9d788 Remove not-needed cadillac-init f0a5d15 typo c093286 Add bootkick after re-enabling phone power (#401) eadb0db security upgrades (#397) 7c13bec Command to get signature (#399) dad439a static assert on size of health packet (#398) da9da46 Fix VERSION df4159c Revert "Revert "Register readback on most modules. Still need to convert the other ones (#396)"" 56ec215 Revert "Register readback on most modules. Still need to convert the other ones (#396)" 893e486 Register readback on most modules. Still need to convert the other ones (#396) 6bbae7b VW safety: allow cancel spam on both buses to be compatible with camera and gateway integration d5f7a28 bump panda 1bcc351 ignition_can: set it to False after 2s of not seeing CAN msgs 96137f1 VW can based ignition not needed. it has ignition line at camera as well. 1b004a1 Same flake8 version as the one in openpilot e82ba5f Same pylint version as the one in openpilot 656f99b Interrupt refactor (NVIC_SM_1: #334) and Fault handling (#377) (PR #373) 000282e Fix can_logger.py to run correctly on python3 (#392) 7f9b4a5 Fix USB device enumeration on Windows 8.1 and Windows 10 (#393) dec565c Update Misra test coverage, which now includes rule 2.7 fb6bc3b Fix Misra 878dd00 solve race condition is relay_malfunction right after changing the relay status by adding a counter 2d4cb05 add a safety mode counter a6797a21 Implement USB power mode on uno 670f90c Merge branch 'master' of github.com:commaai/panda ca39a5d Added faults integer to health packet e1c34a1 Panda Jungle testing (#394) 2a093a3 Added heartbeat to echo test 2246435 Fixed health struct size. We should really get an automated test for this f458d67 Add uptime counter to the health packet (#391) 1662481 enable CAN transcievers outside the set_safety_mode function, which is not related a7c9874 bump panda ver 1192d93 Power saving refactor (#389) d58d08f Fix Misra 17.8: can't mod function params bc685ac Minor indent a54b86c Failure of set_safety_mode falls back to SILENT. Failure to set silent results in hanging 597436d NOOUTPUT safety mode is now SILENT. NOOUTPUT still exists but keeps C… (#388) d229f8d ESP forced off in EON build. this prevents ESP to be turned on when e… (#387) 8a044b3 forgot Hyundai: now also using make_msg 4f9c879 remove abunch of lines from safety regression tests by using common make_msg function fb81414 mispelled word 57f5ef8 Fix misra: addr can't be more than 29 bits anyway 68ff501 typo d5c772b Fixe Toyota message white-list 48197a9 Better masking for ELM mode b8fe78c VW is also tested for safety replay 212d336 Safety Chrysler: Added cancel spam button check d44b562 fix print in example 02d579a functional addr handling 6249a18 tx_hook shall have a white-list of messages (#381) 8138fc1 uds: handle function addrs and fw version query example 6626a54 Fixed python health api b9b79e8 uds zero second timeout e0de1a4 define ALLOW_DEBUG in safety tests 86dec4b Safety modes that violate ISO26262 requirements are not compiled in RELEASE build e74ed93 safety tests a bit more simplified 2027765 relay malfunction test centralized 8af1a01 clean up safety tests e8f7a3b upd panda cfcce8f WIP: Relay malfunction (#384) 69d9d61 No tabs in mazda safety a86418c insignificant changes f239b99 single addr was better d063a18 Hyundai safety: re-enable button spam safety check 4d1edc0 skip tx_hook if a message is forwarded (#379) df2ff04 bump version 168461d added fault state to health packet b3e1a13 uds: better debug prints 68c39fb uds: no need for threads if you always drain rx 91b7c5b bump Panda Ver 26cb4dc Fixed pylint error 32725cc Fixed misra compliance e33b4be Added echo script 312ba62 minor comment cleanupo e90897a Fix board detection on white 0e72c18 always stop executing if safety mode fails to be set (suggested by jyoung8607) e8d7ed1 Rename function name to not confuse safety_set_mode and set_safety_mode ff86db6 improve uds message processing 512ab3f except Exception 37ce507 py3 all bac4d85 dos and python3 501db8d uds drain before send and use has_obd() f2cbec1 Added has_obd() to python library 48e5b18 Add SDK downloading to the build step (#314) e0762c2 Add Python & USB API for controlling phone power (#313) ba9fb69 New health packet struct also in the python libs git-subtree-dir: panda git-subtree-split: a648cca
Vaggysag
pushed a commit
to Vaggysag/openpilot
that referenced
this pull request
Apr 21, 2020
* Added interface for phone power * Add power function in python * Fixed struct
mmmorks
added a commit
to mmmorks/openpilot
that referenced
this pull request
Jun 14, 2022
CarParams: add maxLateralAccel commaai#312 Torque control deadzone commaai#318
mmmorks
added a commit
to mmmorks/openpilot
that referenced
this pull request
Jun 15, 2022
CarParams: add maxLateralAccel commaai#312 Torque control deadzone commaai#318
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
Aug 2, 2024
* ui: Redesign settings sidebar panel * redesign close button * add icon * remove * no icons for now * more adjust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on:
Kia Sorento
Kia Stinger
Hyundai Elantra
Hyundai Genesis
Tuning is WIP: https://docs.google.com/spreadsheets/d/1ZfqAHr1FkchRechv8Pjci9ls7dQ68zuDSPlpvYr7Bz4/edit#gid=0
Safety is WIP