Params: better error logging on constructor #29954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnewb1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the recent CI unittest failures are something with the nonblocking params write. Unclear what the exact cause is, but this will at least allow us to see the errors. Currently if you get an exception in the C params implementation, it causes a fatal python error that seems to totally break pytest and causes the timeout
Before this change: fatal python error on runtime error:
https://github.com/commaai/openpilot/actions/runs/6216166456/job/16869754995#step:5:80
After: doesn't crash pytest and cause a timeout anymore, just shows a failed test:
https://github.com/jnewb1/openpilot/actions/runs/6210296847/job/16860422338#step:5:161