cabana: support display&edit node name #29897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
cabana_show_edit_node
branch
from
1b61bbb to
6b8a39e
Compare
|
Node is fine |
deanlee
force-pushed
the
cabana_show_edit_node
branch
from
efa01a4 to
2978ac5
Compare
|
The signals can have multiple reading nodes. Maybe |
|
modified the validator to support multiple nodes, should be ok now. |
sshane
approved these changes
Sep 14, 2023
deanlee
force-pushed
the
cabana_show_edit_node
branch
from
2ef750b to
673e598
Compare
deanlee
force-pushed
the
cabana_show_edit_node
branch
from
673e598 to
25df7c3
Compare
deanlee
force-pushed
the
cabana_show_edit_node
branch
from
57594b6 to
7ba76eb
Compare
sshane
reviewed
Sep 15, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sshane I use "Node" as the title, what do you think is a better name for it?