Toyota: use torque control for Japanese-made 2023 RAV4 #29896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending a few test routes, is this how you would do it @adeebshihadeh, or split it up into 4 platforms for the ICE and hybrid? |
sshane
changed the title
sshane
changed the title
adeebshihadeh
approved these changes
Sep 13, 2023
selfdrive/car/toyota/interface.py
Outdated
| if fw.ecu == "eps" and not fw.fwVersion == b'8965B42371\x00\x00\x00\x00\x00\x00': | ||
| ret.steerControlType = SteerControlType.torque | ||
|
|
||
| if ret.steerControlType == SteerControlType.angle: |
There was a problem hiding this comment.
these two if's with the same condition in a row is pretty confusing. can you make this more readable?
There was a problem hiding this comment.
Made it one if statement.
sshane
added a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.