Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pandaStates to 10Hz #29889

Merged
merged 26 commits into from
Sep 22, 2023
Merged

bump pandaStates to 10Hz #29889

merged 26 commits into from
Sep 22, 2023

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Sep 12, 2023

With #29923, fixes #29354 by publishing ignition signal faster to put UI into offroad state.

@sshane
Copy link
Contributor Author

sshane commented Sep 15, 2023

Full segment size comparison:

  • 2Hz pandaStates (49c7b83d348197ed|2023-09-15--16-21-47--1):
    • rlog.bz2: 12,019,885 B
    • qlog.bz2: 879,409 B
  • 10Hz pandaStates (49c7b83d348197ed|2023-09-15--16-17-08--1):
    • rlog.bz2: 12,179,348 B (1.32666% increase)
    • qlog.bz2: 911,521 B (3.65154% increase)

@@ -33,7 +34,8 @@
CURRENT_TAU = 15. # 15s time constant
TEMP_TAU = 5. # 5s time constant
DISCONNECT_TIMEOUT = 5. # wait 5 seconds before going offroad after disconnect so you get an alert
PANDA_STATES_TIMEOUT = int(1000 * 1.5 * DT_TRML) # 1.5x the expected pandaState frequency
PANDA_STATES_FREQUENCY = service_list['pandaStates'].frequency
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the point of this duplication?

@sshane sshane marked this pull request as ready for review September 16, 2023 00:19
@sshane
Copy link
Contributor Author

sshane commented Sep 16, 2023

We can also decimate peripheralState in boardd to 2Hz and change what thermald polls for to that service.

@adeebshihadeh
Copy link
Contributor

Why bump perihperalState?

@sshane
Copy link
Contributor Author

sshane commented Sep 16, 2023

No reason, decimated.

after pandaStates
@sshane
Copy link
Contributor Author

sshane commented Sep 16, 2023

Ran can_replay as fast as possible on the Corolla route and interrupt load was mean 0.292 on master and 0.297 on this branch. Igor says that should be fine.

Another benefit of this change is we don't lose OBD multiplexing flips while fingerprinting, better for debugging errors!

@adeebshihadeh
Copy link
Contributor

Ran can_replay as fast as possible on the Corolla route and interrupt load was mean 0.292 on master and 0.297 on this branch. Igor says that should be fine.

Note that this will be different for USB (C3) and SPI (C3X), but the hit from panda states is way less than can traffic, so doesn't matter anyway.

@adeebshihadeh
Copy link
Contributor

What's the qlog hit now that peripheralState is reverted?

@sshane
Copy link
Contributor Author

sshane commented Sep 19, 2023

peripheralState had very little impact.

376bf99325883932:
master: 823,951 bytes, 824,038 bytes, 829,203 bytes, 822,070 bytes
10hz: 838,650 bytes, 840,054 bytes, 843,549 bytes, 836,689 bytes (1.81% increase)

49c7b83d348197ed:
master: 910,727 bytes, 910,556 bytes, 907,888 bytes, 913,848 bytes
10hz: 918,186 bytes, 938,407 bytes, 955,519 bytes, 963,478 bytes (3.64% increase)

@sshane sshane merged commit d47e8f5 into master Sep 22, 2023
22 checks passed
@sshane sshane deleted the 10hz-pandaStates branch September 22, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bolt brief alerts while going offroad
2 participants