-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump pandaStates to 10Hz #29889
bump pandaStates to 10Hz #29889
Conversation
Full segment size comparison:
|
selfdrive/thermald/thermald.py
Outdated
@@ -33,7 +34,8 @@ | |||
CURRENT_TAU = 15. # 15s time constant | |||
TEMP_TAU = 5. # 5s time constant | |||
DISCONNECT_TIMEOUT = 5. # wait 5 seconds before going offroad after disconnect so you get an alert | |||
PANDA_STATES_TIMEOUT = int(1000 * 1.5 * DT_TRML) # 1.5x the expected pandaState frequency | |||
PANDA_STATES_FREQUENCY = service_list['pandaStates'].frequency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the point of this duplication?
We can also decimate peripheralState in boardd to 2Hz and change what thermald polls for to that service. |
Why bump perihperalState? |
No reason, decimated. |
after pandaStates
d508a74
to
5eecb83
Compare
This reverts commit 5eecb83.
Ran can_replay as fast as possible on the Corolla route and interrupt load was mean 0.292 on master and 0.297 on this branch. Igor says that should be fine. Another benefit of this change is we don't lose OBD multiplexing flips while fingerprinting, better for debugging errors! |
Note that this will be different for USB (C3) and SPI (C3X), but the hit from panda states is way less than can traffic, so doesn't matter anyway. |
What's the qlog hit now that peripheralState is reverted? |
peripheralState had very little impact. 376bf99325883932: 49c7b83d348197ed: |
With #29923, fixes #29354 by publishing ignition signal faster to put UI into offroad state.