Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add missing Arabic translations & show in UI #29881

Merged
merged 9 commits into from
Sep 18, 2023
Merged

Conversation

royjr
Copy link
Contributor

@royjr royjr commented Sep 12, 2023

  • Removed vanished
  • Added unfinished translations
  • Cycled offroad events
  • test_translations.py
  • added arabic next to turkish assuming sorting by language regions
  • C3 visual check
Updating 'selfdrive/ui/translations/tmp/main_ar.ts'...
Found 272 source text(s) (0 new and 272 already existing)
Screenshot 2023-09-11 at 8 41 07 PM

@sshane sshane changed the title ui: Arabic Translation ui: add missing Arabic translations & show in UI Sep 12, 2023
@sshane
Copy link
Contributor

sshane commented Sep 12, 2023

If you can, can you test on a C3/3X to make sure that the font looks appropriate (not blocky, missing characters, etc)? It previously didn't for Thai so we added a few at the same time.

@royjr
Copy link
Contributor Author

royjr commented Sep 12, 2023

Looks just as good 👍

@sshane
Copy link
Contributor

sshane commented Sep 16, 2023

المناطق الممتلئة بالدماء
is still there, are you sure that's fine?

@sshane sshane merged commit da4d4cf into commaai:master Sep 18, 2023
@sshane
Copy link
Contributor

sshane commented Sep 18, 2023

thanks!

@royjr royjr deleted the arabic branch September 18, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants