cabana: display warning if failed to write settings #29873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add “settings” to the gitignore? I always have to revert it because it defaults to my workspace directory 😅 |
|
not sure why, but it's already in openpilot/tools/cabana/.gitignore Lines 1 to 7 in 43210ca |
|
Ah, I usually start it from the openpilot directory |
deanlee
force-pushed
the
cabana_display_warning_if_failed_to_write_settings
branch
2 times, most recently
from
b90dc82 to
ff4800f
Compare
deanlee
force-pushed
the
cabana_display_warning_if_failed_to_write_settings
branch
from
ff4800f to
132871c
Compare
deanlee
deleted the
cabana_display_warning_if_failed_to_write_settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my cabana has always reverted to default settings every time I start it up for the past week. Until I found it's a permission issue.
think it's better to display a warning for QSettings::AccessError than silently skipping it.