GM: fix possible steering message counter duplication #27281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After thinking this out, this doesn't make sense. We already handle this pretty well. If OP were to lag so much that we didn't get a readback frame in three 10 ms frames and send a duplicate counter, then all of a sudden get two 128 confirmations, the car would see:
0 -> 0 (OP GETS READBACKS) -> 2
And on master, we'd handle this to the best of our ability by only incrementing once (we still would send a duplicate frame, thinking the steering message got blocked somehow):
0 -> 0 (OP GETS READBACKS) -> 1