Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabana: fix incorrect clamp #27218

Merged
merged 2 commits into from
Feb 5, 2023
Merged

cabana: fix incorrect clamp #27218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea49442
fix incorrect clamp
deanlee Feb 4, 2023
d8ff998
fix type error
deanlee Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/cabana/chartswidget.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,8 +642,8 @@ void ChartView::mouseReleaseEvent(QMouseEvent *event) {
double max = chart()->mapToValue(rect.bottomRight()).x();

// Prevent zooming/seeking past the end of the route
min = std::clamp(min, can->routeStartTime(), can->routeStartTime() + can->totalSeconds());
max = std::clamp(max, can->routeStartTime(), can->routeStartTime() + can->totalSeconds());
min = std::clamp(min, 0., can->totalSeconds());
max = std::clamp(max, 0., can->totalSeconds());

double min_rounded = std::floor(min * 10.0) / 10.0;
double max_rounded = std::floor(max * 10.0) / 10.0;
Expand Down