Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai longitudinal: handle mid-press button change #24674

Merged
merged 5 commits into from
Jun 2, 2022

Conversation

sshane
Copy link
Contributor

@sshane sshane commented May 28, 2022

Should probably common-ize similar code in GM and Honda

@sshane sshane added bugfix car vehicle-specific labels May 28, 2022
@sshane sshane linked an issue May 28, 2022 that may be closed by this pull request
@sshane sshane merged commit dd10a83 into master Jun 2, 2022
@sshane sshane deleted the hkg-long-button-bug branch June 2, 2022 08:27
maxime-desroches pushed a commit that referenced this pull request Jun 4, 2022
* send additional button event for previous if we switch buttons mid-press

* add comment

* remove

* comment
spektor56 pushed a commit to spektor56/ghostpilot that referenced this pull request Jun 30, 2022
* send additional button event for previous if we switch buttons mid-press

* add comment

* remove

* comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix car vehicle-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyundai longitudinal: handle button signal changing mid press
2 participants