-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMC Acadia: Add lateral feedforward function #22899
GMC Acadia: Add lateral feedforward function #22899
Conversation
I support this PR, tested by @Verylukyguy , but haven't had time for the proper before/after plots. |
Here is another, longer route with fewer interventions: e38a02cae1ef1e0c|2021-11-13--23-14-13 There is a seemingly random "Steering Temporarily Unavailable" error in the middle, but it recovered immediately. |
I was really hoping that this would be approved so it would make it into the next release. Please |
We haven't reviewed this since it's missing the verification criteria, and it's too late to get this into 0.8.11. Here's the verification criteria. Converting to draft until that's done.
|
I tried to help, but I can’t fulfill your requirements and your verification criteria. Sorry. I wish that I could help more. I’ll keep checking back to see when your product can better fulfill its expectations. |
This is a duplicate lateral steering tuning improvement for a different model vehicle.
This sigmoidal FeedForward function was previously merged for the GM Volt on PR: #22621
OpenPilot v0.8.11-Master, Lanefull
Route: e38a02cae1ef1e0c|2021-11-10--17-18-10