Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMC Acadia: Add lateral feedforward function #22899

Merged
merged 5 commits into from
Nov 18, 2021
Merged

GMC Acadia: Add lateral feedforward function #22899

merged 5 commits into from
Nov 18, 2021

Conversation

Verylukyguy
Copy link
Contributor

@Verylukyguy Verylukyguy commented Nov 13, 2021

This is a duplicate lateral steering tuning improvement for a different model vehicle.

This sigmoidal FeedForward function was previously merged for the GM Volt on PR: #22621

OpenPilot v0.8.11-Master, Lanefull

Route: e38a02cae1ef1e0c|2021-11-10--17-18-10

@Verylukyguy
Copy link
Contributor Author

solution

@hewers
Copy link
Contributor

hewers commented Nov 14, 2021

I support this PR, tested by @Verylukyguy , but haven't had time for the proper before/after plots.

@adeebshihadeh adeebshihadeh changed the title Add lateral feedforward function to the GMC Acadia GMC Acadia: Add lateral feedforward function Nov 14, 2021
@Verylukyguy
Copy link
Contributor Author

Here is another, longer route with fewer interventions:

e38a02cae1ef1e0c|2021-11-13--23-14-13

There is a seemingly random "Steering Temporarily Unavailable" error in the middle, but it recovered immediately.

@Verylukyguy
Copy link
Contributor Author

I was really hoping that this would be approved so it would make it into the next release. Please

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Nov 18, 2021

We haven't reviewed this since it's missing the verification criteria, and it's too late to get this into 0.8.11. Here's the verification criteria. Converting to draft until that's done.

<!-- To verify tuning, capture the following scenarios (broadly, not exactly), with current tune and this tune.
Use the PlotJuggler tuning layout to compare planned versus actual behavior.

Run ./juggle.py <route> --layout layouts/tuning.xml , screenshot the full tab of interest, and paste into this PR.

Longitudinal:
* Maintaining speed at 25, 40, 65mph
* Driving up and down hills
* Accelerating from a stop
* Decelerating to a stop
* Following large changes in set speed
* Coming to a stop behind a lead car

Lateral:
* Straight driving at ~25, ~45 and ~65mph
* Turns driving at ~25, ~45 and ~65mph
-->

@adeebshihadeh adeebshihadeh marked this pull request as draft November 18, 2021 05:03
@Verylukyguy
Copy link
Contributor Author

I tried to help, but I can’t fulfill your requirements and your verification criteria. Sorry. I wish that I could help more. I’ll keep checking back to see when your product can better fulfill its expectations.

@haraschax haraschax marked this pull request as ready for review November 18, 2021 23:45
@haraschax haraschax merged commit 9578640 into commaai:master Nov 18, 2021
@hewers hewers deleted the gm-acadia-lateral-feedforward branch December 3, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants