Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accel/decel button metric increments #22399

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Conversation

speedking456
Copy link
Contributor

Freedom units have weird multiples compared to metric. Modified so that it increments by 10 km/h on long press and 1 km/h on short press, rather than 8 and 1.6 km/h. This mimics stock hyundai behaviour on metric vehicles.

Freedom units have weird multiples compared to metric. Modified so that it increments by 10 km/h on long press and 1 km/h on short press, rather than 8 and 1.6 km/h. This mimics stock hyundai behaviour on metric vehicles.
@pd0wm
Copy link
Contributor

pd0wm commented Oct 4, 2021

Reverted the changes to minimum cruise speed, want to set those according to ISO 15622:2018

@pd0wm
Copy link
Contributor

pd0wm commented Oct 4, 2021

You're sure hyundai uses 10 km/h increments? Think Honda uses 5 km/h.

@KyleGreenlaw
Copy link
Contributor

Can confirm Hyundai stock system uses +/- 10km/h on long press.

@KyleGreenlaw
Copy link
Contributor

Also min set speed on Hyundai stock is 30km/h, not 40.

@pd0wm
Copy link
Contributor

pd0wm commented Oct 4, 2021

ISO 15622:2018 suggests a min set speed of 4.4 m/s, think I'll be using that but rounded up slightly.

@speedking456
Copy link
Contributor Author

You're sure hyundai uses 10 km/h increments? Think Honda uses 5 km/h.

Honda and Toyota use 5 km/h, Hyundai uses 10, which I prefer as we don’t have any speed limits that end in 5.

Reason for 30 km/h starting speed is that is usually the speed limit for school zones and lowest speed you’d usually go in metric countries around slow streets.

@pd0wm pd0wm merged commit 23b9316 into commaai:master Oct 4, 2021
@spektor56
Copy link
Contributor

spektor56 commented Oct 5, 2021

You're sure hyundai uses 10 km/h increments? Think Honda uses 5 km/h.

Yea Honda / Toyota / Subaru increments by 5 and for Canadians makes more sense. Most people drive above speed limits and you can go 15 km/h over without getting demerit points. 65 on a 50, 75 on a 60 etc.

@Aragon7777
Copy link

ISO 15622:2018 suggests a min set speed of 4.4 m/s, think I'll be using that but rounded up slightly.

These latest changes have broken both of my Hondas.. badly. Not sure if it's the rounding logic being used or something else but it's skipping all over the place and gets stuck if holding the button down.

Spektor's version of this which has worked for a while is the only one I've tried so far that always lines up with the hud completely, no hiccups. Maybe some of the rounding logic from there could be used...?

spektor56@3532ed5

@pd0wm
Copy link
Contributor

pd0wm commented Oct 7, 2021

What change broke things? The short/long press 1/5 mph, or this pr with the metric changes?

Do you have a route?

@speedking456 speedking456 deleted the patch-1 branch March 1, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants