c++ replay: more robust seek #22375
Merged
c++ replay: more robust seek #22375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deanlee
commented
Sep 29, 2021
•
deanlee
commented
- more robust seek .
- skip invalid segments
- faster merge events
- test cases
- reduce cpu usage ~20%
deanlee
force-pushed
the
replay_skip_invalid_segments
branch
2 times, most recently
from
d607b54 to
d3b2990
Compare
|
Does this also handle seeking past the end of the route? |
|
It should be handled, I need to write some test cases int this PR to ensure the stability of seek |
deanlee
force-pushed
the
replay_skip_invalid_segments
branch
5 times, most recently
from
65be002 to
20e1198
Compare
deanlee
changed the title
deanlee
force-pushed
the
replay_skip_invalid_segments
branch
from
ccd323a to
8030a40
Compare
deanlee
force-pushed
the
replay_skip_invalid_segments
branch
from
8030a40 to
740e950
Compare
|
How much faster is the merge by doing things in parallel? I'm worried that depending on |
|
not too much, merge 5 segments, from ~9ms-> ~0.5 ms. sort events in loggerread, from 8ms->0.3 ms |
|
Yeah, let's remove it. It's not installed on AGNOS. |
cleanup remoe & typo update comment
This reverts commit d7d1b42.
deanlee
force-pushed
the
replay_skip_invalid_segments
branch
from
8a2e000 to
97c380e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.