c++ replay: graceful shutdown #22280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
replay_shutdown
branch
2 times, most recently
from
1cb3f33 to
fbf0da2
Compare
2 tasks
deanlee
force-pushed
the
replay_shutdown
branch
from
fbf0da2 to
8cb2ed1
Compare
deanlee
force-pushed
the
replay_shutdown
branch
2 times, most recently
from
7004fe7 to
b6eae58
Compare
deanlee
force-pushed
the
replay_shutdown
branch
from
b6eae58 to
c5e636a
Compare
|
I'm still seeing some camerad server/VisionIPC shutdown messages after the replay destructor. Is that intended? |
|
The camera is released after print "shutdown: done" caused output's order problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.