Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mazda BSM #1830

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Mazda BSM #1830

merged 2 commits into from
Jul 6, 2020

Conversation

Jafaral
Copy link
Contributor

@Jafaral Jafaral commented Jul 6, 2020

Plus a couple of new fingerprints

Jafaral added 2 commits July 4, 2020 11:32
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
@@ -139,6 +142,8 @@ def get_can_parser(CP):
("SET_P", "CRZ_BTNS", 0),
("SET_M", "CRZ_BTNS", 0),
("CTR", "CRZ_BTNS", 0),
("LEFT_BS1", "BSM", 0),
("RIGHT_BS1", "BSM", 0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's a bunch of BSM signals defined in the DBC, but it's not clear what they are. Can you add comment lines to the DBC?

@adeebshihadeh adeebshihadeh merged commit d5d0e75 into commaai:master Jul 6, 2020
linu1983 added a commit to linu1983/openpilot that referenced this pull request Dec 3, 2020
Add AutoHold feature for GM
code written by lfverit(lfv#7315) & Linu Choi(최광수)commaai#1830
@Jafaral Jafaral deleted the bsm branch August 24, 2021 05:31
brymut pushed a commit to brymut/openpilot that referenced this pull request Mar 3, 2025
* Hyundai CAN-FD safety: Refactor bus detections

* try this

* theh same

* we don't use a-can in safety

* nah just 1 fix for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants