Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup improvements #109

Merged
merged 3 commits into from
Feb 24, 2023
Merged

setup improvements #109

merged 3 commits into from
Feb 24, 2023

Conversation

incognitojam
Copy link
Member

@incognitojam incognitojam commented Feb 7, 2023 •
edited
Loading

@incognitojam incognitojam added the enhancement New feature or request label Feb 7, 2023
@incognitojam incognitojam changed the title new setup setup improvements Feb 7, 2023
adeebshihadeh
adeebshihadeh requested changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment •
edited by incognitojam
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining TODOs

  • write setup URL somewhere, such as /tmp/setup_url
  • show a more specific error when we didn't download a valid installer binary
  • add a test plan to internal/README.md for the setup that hits all states
  • go through setup tests

@incognitojam incognitojam mentioned this pull request Feb 22, 2023
Merged
@adeebshihadeh adeebshihadeh merged commit 5567af9 into master Feb 24, 2023
@adeebshihadeh adeebshihadeh deleted the setup-no-defaults branch February 24, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@incognitojam @adeebshihadeh