Optimize recursive_output_delete_if_changed and recursive_will_execute increasing speed by 1000x +
#1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgthree
changed the title
recursive_output_delete_if_changed increasing speed by 1000x +recursive_output_delete_if_changed and recursive_will_execute increasing speed by 1000x +
|
Hey @comfyanonymous wdyt about optimizing these calls? If it’s a no go, I can just (sloppily) patch it for https://github.com/rgthree/rgthree-comfy node users there, but it feels like a valuable optimization for everyone. |
Merged
|
Looking forward to this PR getting merged |
Yea, I've stopped holding my breath. Good news is if you're already using rgthree-comfy then these have been patched and optimized since September! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #1502, increasing execution speed of re-executed workflows by a significant amount (scales exponentially as more nodes are added).
The change caches the
to_deletevalue by a given node's output at the prompt level (inexecute) allowingrecursive_output_delete_if_changedto skip nodes whose outputs have already been recursively evaluated.(While
outputsalready pops nodes off effectively stopping evaluation for already deleted nodes, this change caches ato_delete = Falsevalue, allowing the execution to reuse that work)