Fix page seed import with attached file path containing white space c…

…haracters (#837) * Fix errors when importing page seed with attached file path containing whitespace characters. Issue #836 * Update seed data & test to fail prior to fix for Issue #836
comfy · Aug 5, 2018 · 542d768 · 542d768
1 parent b7bdfd3
commit 542d768
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 2 deletions.
diff --git a/db/cms_seeds/sample-site/pages/index/cms logo.png b/db/cms_seeds/sample-site/pages/index/cms logo.png
diff --git a/db/cms_seeds/sample-site/pages/index/content.html b/db/cms_seeds/sample-site/pages/index/content.html
@@ -22,3 +22,4 @@
 [files attachments]
 header.png
 footer.png
+cms logo.png
diff --git a/lib/comfortable_mexican_sofa/seeds/page/importer.rb b/lib/comfortable_mexican_sofa/seeds/page/importer.rb
@@ -187,7 +187,7 @@ def construct_fragments_attributes(hash, record, path)
     # ActiveStorage and a list of ids of old attachements to destroy
     def files_content(record, identifier, path, frag_content)
       # preparing attachments
-      files = frag_content.split.collect do |filename|
+      files = frag_content.split("\n").collect do |filename|
         file_handler = File.open(File.join(path, filename))
         {
           io:           file_handler,

diff --git a/test/lib/seeds/pages_test.rb b/test/lib/seeds/pages_test.rb
@@ -61,7 +61,7 @@ def test_creation
     assert_equal 1, frag.attachments.count
 
     frag = page.fragments.find_by(identifier: "attachments")
-    assert_equal 2, frag.attachments.count
+    assert_equal 3, frag.attachments.count
 
     assert_equal 2, page.categories.count
     assert_equal %w[category_a category_b], page.categories.map(&:label)