Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot cometbft-rs versions as 0.1.0 #8

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

mzabaluev
Copy link
Contributor

As we've got new crate names to release, we are free to restart the versioning.

As we've got new crate names to release, we are free to restart the versioning.
romac
romac previously approved these changes Jan 19, 2024
@romac
Copy link
Collaborator

romac commented Jan 23, 2024

Given that we've been using these crates in many places for the past few years, how about rebooting with version 1.0 instead to signal the stability it now deserves imho? We can perhaps add a -alpha.N suffix until we've successfully integrated it in Hermes/ibc-rs/etc.

What do you think, @mzabaluev @sergio-mena @ancazamfir?

@romac romac dismissed their stale review January 23, 2024 09:13

See comment above

@mzabaluev
Copy link
Contributor Author

mzabaluev commented Jan 24, 2024

Given that we've been using these crates in many places for the past few years, how about rebooting with version 1.0 instead to signal the stability it now deserves imho?

The semver restrictions will apply to the Rust crates, including anything we have to change purely on the Rust side not connected to any changes in CometBFT in general. I don't have confidence at all that we are at the stage where we can commit to supporting the API at any long stretch of time, before we need to cut a new major version. With 0.x, we just bump the minor version instead like we always did.

Among other things, we need to have a prost-types vs. pbjson-types vs. roll-your-own showdown (see informalsystems/tendermint-rs#1053), and anything else that will fall out of the buf rework.

@romac
Copy link
Collaborator

romac commented Jan 25, 2024

I see what you mean, so yeah in any case we should stay at 0.x until we figure out the story around prost-types, but, etc. and also until we are able to confirm that cometbft-rs works for our purpose in Hermes.

After that, we can discuss whether or not we feel like the crate deserves at v1 or not. Keeping in mind that we can always release new major versions if needed, and do not have to commit to maintaining previous major versions indefinitely.

@mzabaluev
Copy link
Contributor Author

In a call with @romac we have agreed to start with a pre-release version to test the release script.

Need a pre-release version to test the release script.
@mzabaluev mzabaluev merged commit 438e464 into main Jan 26, 2024
24 checks passed
@mzabaluev mzabaluev deleted the mikhail/reboot-version-0.1 branch January 26, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants