Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPIK-669: Make containers start when test instance is init #1412

Conversation

thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Feb 27, 2025

Details

In this PR, we introduce a new Junit5 extension that allows us to postpone the application context setup to the before-all method. This makes the container instance-based instead of static-based, making container initialization lazy instead of eager.

Testing

Tested via CI

@thiagohora thiagohora self-assigned this Feb 27, 2025
@thiagohora thiagohora marked this pull request as ready for review February 27, 2025 17:28
@thiagohora thiagohora requested a review from a team as a code owner February 27, 2025 17:28
@thiagohora thiagohora force-pushed the thiagohora/OPIK-669_make_containers_start_when_test_instance_is_instanciated branch from a050be4 to b44473b Compare February 28, 2025 08:37
Copy link
Contributor

@idoberko2 idoberko2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagohora thiagohora merged commit f80fc7a into main Mar 3, 2025
8 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-669_make_containers_start_when_test_instance_is_instanciated branch March 3, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants