Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adding missing doc annotations #20

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

juancho0202
Copy link
Contributor

Closes #15

Do not merge until #14 is merged.

@juancho0202 juancho0202 requested a review from Stef3st November 6, 2023 09:06
@Stef3st Stef3st changed the title DON'T MERGE | doc: adding missing doc annotations doc: adding missing doc annotations Nov 7, 2023
@Stef3st Stef3st closed this Nov 7, 2023
@Stef3st Stef3st reopened this Nov 7, 2023
@juancho0202 juancho0202 force-pushed the 15-add-doc-annotations branch from 1c33500 to a85625e Compare November 7, 2023 15:35
Copy link
Collaborator

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a few minor things. Mostly is that a decission needs to be made if the private properties should be included. Either make annotations/descriptions for all of them or leave them all out 😄

@juancho0202 juancho0202 requested a review from Stef3st November 8, 2023 14:10
Copy link
Collaborator

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stef3st Stef3st merged commit e1fb71f into main Nov 8, 2023
3 checks passed
@Stef3st Stef3st deleted the 15-add-doc-annotations branch November 8, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doc annotations to the plugins and components
2 participants