#989 Correct error line and column number

[joan38]

No description provided.

[joan38]

Not sure it might be spacePointer here.
Also not sure if it starts from 1 or 0. I need to do some testing.

[ckipp01]

Thanks for taking a look at this @joan38! Just tested it out, and much better!

One other thing that I do notice though is that the diagnostic from Mill is as follows:

"diagnostics": [
    {
      "range": {
        "start": {
          "line": 8,
          "character": 15
        },
        "end": {
          "line": 8,
          "character": 15
        }
      },
      "severity": 1,
      "source": "compiler from mill",
      "message": "type mismatch;\n found   : String(\"hi\")\n required: Int"
    }
  ],

Whereas both with sbt and with Bloop it's:

"diagnostics": [
    {
      "range": {
        "start": {
          "line": 8,
          "character": 15
        },
        "end": {
          "line": 8,
          "character": 19
        }
      },
      "severity": 1,
      "source": "sbt",
      "message": "type mismatch;\n found   : String(\"hi\")\n required: Int"
    }
  ]

It still seems to work fine (I think there is some magic on the LSP client side) to maybe highlight the full symbol, but it'd be better to correctly capture the entire range and not return 15 for both start character and end character.

If it helps at all, here is the code sbt uses to get the range from the Problem.

https://github.com/sbt/sbt/blob/13b09bcd8fa0fde86aa4f4f8d7089fcb18e345c6/main/src/main/scala/sbt/internal/server/BuildServerReporter.scala#L133-L159

[lefou]

Looks good to me.

[lefou]

Merging this as it makes BSP error reporting significantly better. I'll open another issue for the open issue with the range end position.

[lefou]

Thanks you @joan38 for the fix and @ckipp01 for the feedback!