-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup mill.define.Module
and mill.define.Ctx
#4518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module.scala
mill.define.Module
and mill.define.Ctx
8c49ab6
to
65858b0
Compare
b2cdd8e
to
752a471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle the necessary things we want to propagate together under
Ctx.Nested
, rather than passing a loose bunch of implicits. This reduces the amount of implicits we have flying around, and lets us easily mark fields onCtx.Nested
asprivate
where possible so we can add or remove themStandardize naming convention of module members as
module*
:moduleDirectChildren
,moduleCtx
, etc. Fixes RenamemillSourcePath
#4111 by renamingmillSourcePath
tomoduleDir
Clean up
mill.define.Ctx
, removing a bunch of the special case semantics aroundRootModule
/SubfolderModule
Add some basic unit tests in
core/define/test/src/mill/define/ModuleTests.scala
to assert on the module instantiation and context propagation, without the complexity of downstream tests inexec
orresolve
Introduced
mill.define.internal
package, which is stuff inmill.define
that isn't really intended for direct use. Some of it isprivate
but needs to be in this module, some of it can't beprivate
but isn't really meant to be used directly.