Write a doc example on multi-language Mill projects #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lihaoyi is there a need for tests on each languages section? Added test for just the server (which kind of tests the other modules) |
…-multi-language # Conflicts: # example/large/multi/14-multi-language/server/src/com/example/HelloSpringBoot.java
lihaoyi
reviewed
Feb 5, 2025
lihaoyi
reviewed
Feb 5, 2025
|
@monyedavid yes let's add one tiny test suite for each of the the Python and Javascript modules, just to demonstrate how it is done. Left some other comments, but otherwise looks great |
lihaoyi
reviewed
Feb 5, 2025
# Conflicts: # docs/modules/ROOT/pages/large/multi-file-builds.adoc
|
I think this looks great. @monyedavid can you also open a PR backporting this to |
monyedavid
added a commit
to monyedavid/mill
that referenced
this pull request
Feb 6, 2025
…ihaoyi#4476) This pr implements com-lihaoyi#4426 Checklist: - [x] **large/multi/14-multi-language** - [x] React client - [x] Spring server - [x] Simple Python ML binary --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit cdf6055)
monyedavid
added a commit
to monyedavid/mill
that referenced
this pull request
Feb 6, 2025
…ihaoyi#4476) This pr implements com-lihaoyi#4426 Checklist: - [x] **large/multi/14-multi-language** - [x] React client - [x] Spring server - [x] Simple Python ML binary --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit cdf6055)
lihaoyi
added a commit
that referenced
this pull request
Feb 6, 2025
Back-port PR #4476 into `0.12.x` --------- Co-authored-by: Li Haoyi <haoyi.sg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements #4426
Checklist: