Use coursier thread pool to run coursier-related task #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Never use the global |
Using the default global ExecutionContext, also used by the BSP server, can lead to deadlocks, as coursier doesn't mark blocking things with `blocking`.
alexarchambault
force-pushed
the
fix-bsp-deadlock
branch
from
f5aec90
to
34321e1
Compare
lihaoyi
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the default global
ExecutionContext, also used by the BSP server, can lead to deadlocks, as coursier doesn't mark blocking things withblocking. (It deadlocks locally for me, during Mill import via BSP in IntelliJ, with 4 threads being spawned and awaiting in the defaultExecutionContext.)