-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Evaluator Closeable #3600
base: main
Are you sure you want to change the base?
Make Evaluator Closeable #3600
Conversation
95ca64c
to
89b7a87
Compare
I decided to open a PR for that for #3579 (#3579 (comment) in particular), but I'm now realizing this might not be needed for it after all. Don't know what you think of that, I think it's a good idea to clean up things when the |
Cleaning-up the worker cache upon close
89b7a87
to
da9397b
Compare
(This makes |
I'm not sure this is the right thing to do. Right now in production, the That code around sharing stuff across |
It seems this works at the end (CI is green), as in the watch loop, the previous |
Yeah that's why it's green, and then the next question is more what should the logic be here? I don't actually know, but although the current logic of injecting the |
Cleaning-up the worker cache upon close