Fix ScalaTest testOnly include option #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes com-lihaoyi#3440 The problem is mill define all the test tasks with `explicitlySpecified` to be `true`. This result this test always be included. [Code](https://github.com/scalatest/scalatest/blob/main/jvm/core/src/main/scala/org/scalatest/tools/Framework.scala#L267) in Scalatest for related logic.
|
@wb14123 as I mentioned in the other ticket, email me your bank details and I can transfer you the bounty. |
|
Hey @lihaoyi , I Emailed you yesterday from bin.wang@mail.binwang.me to haoyi.sg@gmail.com. Did you receive that? Maybe in spam? |
|
@wb14123 found it! Not sure why it ended up in spam. I'll continue via email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3440
The problem is mill defines all the test tasks with
explicitlySpecifiedto betrue. This makes all the tests always be included. Related code in Scalatest.