Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JavaModule.mandatoryJavacOptions #3503

Merged
merged 11 commits into from
Sep 10, 2024
Merged

Add JavaModule.mandatoryJavacOptions #3503

merged 11 commits into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Add JavaModule.managedJavacOptions 

    This will hold options contributed by traits like `ErrorProneModule`.

Those are not propagated to the inner test trait intentionally, since those options are typically configured by other means, e.g. dedicated targets.
    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    00aef27 View commit details
    Browse the repository at this point in the history

  2. .

    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    42309a9 View commit details
    Browse the repository at this point in the history

  3. fix test

    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2b30877 View commit details
    Browse the repository at this point in the history

  4. .

    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4bd69ef View commit details
    Browse the repository at this point in the history

  5. Some more deprecation fixes

    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d05d059 View commit details
    Browse the repository at this point in the history

  6. Update scalalib/src/mill/scalalib/JavaModule.scala

    @lefou
    lefou authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    88a8056 View commit details
    Browse the repository at this point in the history

  7. Standardize on mandatoryJavacOptions for consistency with pre-exist… 

    …ing targets
    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cf07b22 View commit details
    Browse the repository at this point in the history

  8. .

    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c976b5f View commit details
    Browse the repository at this point in the history

  9. Don't propagae mandatoryScalacOptions to tests, too 

    Needed to add a MiMa exclusion, which should be safe in this case.
    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    db2299c View commit details
    Browse the repository at this point in the history

  10. scalafmt

    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d682244 View commit details
    Browse the repository at this point in the history

  11. Fix test: we no longer expect this one

    @lefou
    lefou committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fb90566 View commit details
    Browse the repository at this point in the history