Preserve caches between interactive and client/server mode #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
commented
May 20, 2018
| } | ||
| current = current.getParent(); | ||
| } | ||
| if (Util.isJava9OrAbove) { |
There was a problem hiding this comment.
@robby-phd do you remember what this was for, or why we need it?
There was a problem hiding this comment.
It was always there before I worked on changing mill client; I assume it's to propagate classpath to the spawned server.
There was a problem hiding this comment.
@robby-phd how about the System.getProperty("java.class.path") logic? It looks like you added it in a9d4eea#diff-00b5b77d5f332c03ac7aa4d9ac51c941R29
|
Ok, maybe in that case I can get rid of it then
…On Sat, 19 May 2018 at 8:08 PM, Robby ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In main/client/src/mill/main/client/MillClientMain.java
<#342 (comment)>:
> @@ -11,20 +11,8 @@
public class MillClientMain {
static void initServer(String lockBase, boolean setJnaNoSys) throws IOException,URISyntaxException{
- ArrayList<String> selfJars = new ArrayList<String>();
- ClassLoader current = MillClientMain.class.getClassLoader();
- while(current != null){
- if (current instanceof java.net.URLClassLoader) {
- URL[] urls = ((java.net.URLClassLoader) current).getURLs();
- for (URL url: urls) {
- selfJars.add(new File(url.toURI()).getCanonicalPath());
- }
- }
- current = current.getParent();
- }
- if (Util.isJava9OrAbove) {
It was always there before
<https://github.com/lihaoyi/mill/blob/122122729d8567e389f434cfb1c074d3119b0088/clientserver/src/mill/clientserver/Client.java#L14-L25>
I worked on changing mill client; I assume it's to propagate classpath to
the spawned server.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#342 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA5A_M3E31hr7q9dWPpI6CDA-4mFw0gzks5t0N46gaJpZM4UF6ur>
.
|
lihaoyi
added a commit
that referenced
this pull request
May 20, 2018
We were incorrectly duplicating the JDK classpath as part of the application classpath when we spawned the Mill server from the Mill client. This makes the transmission of application classpath to the Mill server explicit via an environment variable, so we don't end up including random things from the client classloader hierarchy that we didn't expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly duplicating the JDK classpath as part of the application classpath when we spawned the Mill server from the Mill client. This makes the transmission of application classpath to the Mill server explicit via an environment variable, so we don't end up including random things from the client classloader hierarchy that we didn't expect