Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2.13.13 and 2.12.19 to supported bridges list #3066

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Mar 8, 2024

The bridges are already on Maven Central.

Pull Request: #3066

@lolgab lolgab requested a review from lefou March 8, 2024 15:40
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't needed anywhere except when trying to publish them with the all value in MILL_COMPILER_BRIDGE_VERSIONS env var, right?

It would be good, if we could set this env var in some CI job, to cover any issues with bridge modules.

@lolgab
Copy link
Member Author

lolgab commented Mar 8, 2024

No, they are used by mill to decide if try to get the precompiled bridge via coursier, or to compile the bridge in place. With current mill if you use Scala 2.13.13 you see the Compiling compiler bridge log.
Ideally IMO, we would try anyways, and then in case we get a not found from coursier mill should fallback to compile the bridge in place. Otherwise you lose the precompiled bridge if you don't update Mill to the latest snapshot when a new version of Scala is released.

@lefou
Copy link
Member

lefou commented Mar 8, 2024

That means, no older Mill version is using the bridges. I also think we should always try to download them.

@lolgab lolgab merged commit 4971800 into com-lihaoyi:main Mar 8, 2024
38 checks passed
@lolgab lolgab deleted the add-bridge branch March 8, 2024 19:19
@lefou lefou added this to the 0.11.8 milestone Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants