Introduce mill.api.MillException to transport the error condition
#2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
changed the title
mill.api.MillException to transport the error condition
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this in various situations, so I created this PR as a base for other PRs. It's ok to keep this unmerged until we need it.
Not all build inconsistencies can't be detected before we start evaluation and not all can be reported as evaluation errors, hence this PR add an additional way to exit Mill with a proper error message. You can throw a
mill.api.MillException. It will be handled inMillMainas well asMillClientMain, our central entry points to Mill. The error message will be reported to the user and Mill exits with code 1. No stack trace will be shown.Pull request: #2789