-
-
Notifications
You must be signed in to change notification settings - Fork 364
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix resolution of children of
override lazy val
modules (#3270)
This was preventing resolution of modules in the form `override lazy val foo: FooModule = new FooModule{...}`, which are necessary when you want to override one module with another. You couldn't resolve them via `resolve` or run them from the command line, but you could depend on them from other modules and have then get picked up by planning logic These turn up in Mill's own build, and I notice I couldn't resolve e.g. `main.codesig.test.cases[callgraph-basic-1-static-method].compile` before this PR. After this PR, I can. Filtering out `abstract` methods in `Reflect` seems unnecessary, since compilation checks that every method is implemented already. Added a unit test to cover this edge case. Pull request: #3270
- Loading branch information
Showing
3 changed files
with
26 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters