-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Fail parser with a custom error message #244
Conversation
Please let me know if you want me to change anything, @lihaoyi |
No interest? |
@byF sorry just got to this. Is there any reason you are passing in |
@@ -3,8 +3,10 @@ target/ | |||
out/ | |||
.DS_STORE | |||
*.iml | |||
.idea/ | |||
.idea | |||
.coursier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks unrelated
.bloop/ | ||
.metals/ | ||
project/metals.sbt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks unrelated
Weirdly enough |
It's useful to have a way how to specify a custom error message for the
Fail
parser; the current workaround is to throw an exception instead of using theFail
parser.The implementation is backwards-compatible, the original
Fail
signature doesn't change and it works the same way as before.The updated version assumes the user wants to have the access to the custom error message even if
ctx.verboseFailures
is not true.Issue: closes #243