Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLN Allow to translate column name Select #270

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

pschiffe
Copy link
Contributor

Description

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this.
The change will be automatically tagged by GitHub Actions.
The string won't appear in transifex until our next translation pull task is generated.

@@ -248,7 +248,7 @@ public function getColumnAttributes($gridField, $record, $columnName)
public function getColumnMetadata($gridField, $columnName)
{
if ($columnName == 'BulkSelect') {
return array('title' => 'Select');
return array('title' => _t('GRIDFIELD_BULK_MANAGER.SELECT_LABEL', 'Select'));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone seeing this in the future, note that I'm not requesting a change to __CLASS__ here because this format matches the way translatable strings are defined in this module, which is a departure from other supported modules.

@GuySartorelli
Copy link
Collaborator

Failing JS CI is unrelated to the changes in this PR.

@GuySartorelli GuySartorelli merged commit bdefd14 into colymba:3.1 Mar 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants