Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: publishRecursive() is part of RecursivePublishable, not Versioned #200

Merged
merged 1 commit into from
Jun 28, 2022
Merged

FIX: publishRecursive() is part of RecursivePublishable, not Versioned #200

merged 1 commit into from
Jun 28, 2022

Conversation

kinglozzer
Copy link
Contributor

This change allows non-versioned records to publish their “owned” objects (i.e. image relations) immediately

@GuySartorelli
Copy link
Collaborator

GuySartorelli commented Jun 28, 2022 •
edited
Loading

Given that this was checking hasExtension('Versioned') instead of passing in the full namespaced classname, and there were no failing tests, it seems like this might need a new unit test?
Edit: Nevermind, I've just realised there are no tests on this module.

@GuySartorelli GuySartorelli merged commit 1c5ae8a into colymba:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinglozzer @GuySartorelli